Separate base tests from eventuals test target #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benh
approved these changes
May 21, 2022
test/BUILD.bazel
Outdated
| cc_test( | ||
| name = "eventuals", | ||
| cc_library( | ||
| name = "eventuals-tests", |
There was a problem hiding this comment.
I'd like to suggest base here to mimic the naming in eventuals/BUILD.bazel:
Suggested change
| name = "eventuals-tests", | |
| name = "base", |
|
@FolMing is the Linux build failing due to this change? |
Yes, this definitely shouldn't happen, there must be a bug/inconsistency in how we build curl, I'll look into that. |
NikitaNikolaenko
force-pushed
the
folming.separate-base-tests
branch
4 times, most recently
from
9a9d172 to
a3dc780
Compare
NikitaNikolaenko
force-pushed
the
folming.separate-base-tests
branch
from
a3dc780 to
b5f6dd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we change anything in tests/concurrent - bazel will rebuild all of the base eventuals tests. This PR addresses this issue.